add support for Preselection element #4790
Conversation
|
Related issue: #4513 |
| } | ||
|
|
||
| function _createConfiguration(type, rep, codec) { | ||
| function _createConfiguration(type, rep, codec, prsl_rep) { |
There was a problem hiding this comment.
Use camel case instead of underscore notation
| } | ||
|
|
||
| function _createVideoConfiguration(rep, codec) { | ||
| function _createVideoConfiguration(rep, codec, prsl_rep) { |
There was a problem hiding this comment.
Use camel case instead of underscore notation
stschr
force-pushed
the
dolby/20250610_preselectionSupport
branch
from
7f6b8ed to
fd1312d
Compare
|
@stschr I think you are still working on this PR right? |
No further work is planned for this. Let me rebase... |
stschr
force-pushed
the
dolby/20250610_preselectionSupport
branch
from
c9cb90d to
fd3f122
Compare
src/core/Settings.js
Outdated
| * - Constants.TRACK_SWITCH_MODE_NEVER_REPLACE | ||
| * Do not replace existing segments in the buffer | ||
| * | ||
| * @property {} [includePreselectionsInMediainfo: true] |
There was a problem hiding this comment.
Thanks, that makes it much clearer. I suggest we rename this attribute to includePreselectionsInMediainfoArray. That makes it clearer that the Preselections are an additional entry in the array.
src/dash/models/DashManifestModel.js
Outdated
| return adaptation && adaptation.Representation && adaptation.Representation.length > 0 ? adaptation.Representation[0].mimeType : null; | ||
| } | ||
|
|
||
| function getMimeTypeForPreselection(preselection, adaptations) { |
There was a problem hiding this comment.
Do we need this function? I don't see any usages of it
There was a problem hiding this comment.
same as above (see getIsTextForPreselection())
There was a problem hiding this comment.
I prefer to remove it at this stage, as it is not (yet) used.
| */ | ||
| class Preselection { | ||
| constructor() { | ||
| this.period = null; |
There was a problem hiding this comment.
Thanks, 6th edition specifies: id: default=1
stschr
force-pushed
the
dolby/20250610_preselectionSupport
branch
from
b7b5e5f to
9bcb4f3
Compare
|
Ok, all comments from today addressed... |
github-project-automation
bot
moved this from In Progress
to Done
in dash.js Version 5.1.0
2 participants
Preselections: